From 1f224bef228c496d789aeed1f44c6517668107a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?soy=EF=BC=8A?= <46652463+soy-asterisk@users.noreply.github.com> Date: Sun, 5 Jan 2025 05:23:34 +0900 Subject: [PATCH 1/3] Fixed a bug where notes (NoteGroup) were not destroyed when StrumLine was destroyed. (#519) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Fixed a bug where notes (NoteGroup) were not destroyed when StrumLine was destroyed. * using destroyutil --------- Co-authored-by: ⍚~Nex <87421482+NexIsDumb@users.noreply.github.com> --- source/funkin/game/StrumLine.hx | 1 + 1 file changed, 1 insertion(+) diff --git a/source/funkin/game/StrumLine.hx b/source/funkin/game/StrumLine.hx index 3e88bc7c..b5880acc 100644 --- a/source/funkin/game/StrumLine.hx +++ b/source/funkin/game/StrumLine.hx @@ -292,6 +292,7 @@ class StrumLine extends FlxTypedGroup { super.destroy(); if(startingPos != null) startingPos.put(); + notes = FlxDestroyUtil.destroy(notes); } /** From 2557fc4fb373ec09eee9b19642fb36bee909c72d Mon Sep 17 00:00:00 2001 From: Microkat <89645987+KadePleaseHelpMe@users.noreply.github.com> Date: Mon, 6 Jan 2025 18:30:13 -0500 Subject: [PATCH 2/3] Allow for Float as BPM (#489) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Allow for Float as BPM Please bro 🙏 * making it unlimited --------- Co-authored-by: ⍚~Nex <87421482+NexIsDumb@users.noreply.github.com> --- source/funkin/backend/chart/EventsData.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/funkin/backend/chart/EventsData.hx b/source/funkin/backend/chart/EventsData.hx index d443218a..79f0e210 100644 --- a/source/funkin/backend/chart/EventsData.hx +++ b/source/funkin/backend/chart/EventsData.hx @@ -31,7 +31,7 @@ class EventsData { {name: "Time (Steps)", type: TFloat(0.25, 9999, 0.25, 2), defValue: 4}, {name: "Camera", type: TDropDown(['camGame', 'camHUD']), defValue: "camHUD"} ], - "BPM Change" => [{name: "Target BPM", type: TFloat(1), defValue: 100}], + "BPM Change" => [{name: "Target BPM", type: TFloat(1.00, null, 0.001, 3), defValue: 100}], "Scroll Speed Change" => [ {name: "Tween Speed?", type: TBool, defValue: true}, {name: "New Speed", type: TFloat(0.01, 99, 0.01, 2), defValue: 1.}, From 1facc82073b9a06b861d1987a162f8aecbec46f1 Mon Sep 17 00:00:00 2001 From: Ne_Eo Date: Fri, 10 Jan 2025 16:22:32 +0100 Subject: [PATCH 3/3] Fix credits menu bg not being able to be animated --- source/funkin/menus/credits/CreditsMain.hx | 2 +- source/funkin/options/OptionsMenu.hx | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/source/funkin/menus/credits/CreditsMain.hx b/source/funkin/menus/credits/CreditsMain.hx index 847d2b64..6da46187 100644 --- a/source/funkin/menus/credits/CreditsMain.hx +++ b/source/funkin/menus/credits/CreditsMain.hx @@ -11,7 +11,7 @@ class CreditsMain extends TreeMenu { var items:Array = []; public override function create() { - bg = new FlxSprite(-80).loadGraphic(Paths.image('menus/menuBGBlue')); + bg = new FlxSprite(-80).loadAnimatedGraphic(Paths.image('menus/menuBGBlue')); // bg.scrollFactor.set(); bg.scale.set(1.15, 1.15); bg.updateHitbox(); diff --git a/source/funkin/options/OptionsMenu.hx b/source/funkin/options/OptionsMenu.hx index 497bfd9b..30662136 100644 --- a/source/funkin/options/OptionsMenu.hx +++ b/source/funkin/options/OptionsMenu.hx @@ -31,6 +31,8 @@ class OptionsMenu extends TreeMenu { } ]; + var bg:FlxSprite; + public override function create() { super.create(); @@ -38,7 +40,7 @@ class OptionsMenu extends TreeMenu { DiscordUtil.call("onMenuLoaded", ["Options Menu"]); - var bg:FlxSprite = new FlxSprite(-80).loadAnimatedGraphic(Paths.image('menus/menuBGBlue')); + bg = new FlxSprite(-80).loadAnimatedGraphic(Paths.image('menus/menuBGBlue')); // bg.scrollFactor.set(); bg.scale.set(1.15, 1.15); bg.updateHitbox();