From 6e52f80c9bf8716b6378909650a3f832e3839cdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=8D=9A=7ENex?= <87421482+NexIsDumb@users.noreply.github.com> Date: Sun, 9 Jul 2023 10:42:17 +0200 Subject: [PATCH] Credits Crash Fix when no connection (#181) Avatars were causing this --- source/funkin/menus/credits/CreditsCodename.hx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/source/funkin/menus/credits/CreditsCodename.hx b/source/funkin/menus/credits/CreditsCodename.hx index 23b87416..42b8b4e7 100644 --- a/source/funkin/menus/credits/CreditsCodename.hx +++ b/source/funkin/menus/credits/CreditsCodename.hx @@ -21,12 +21,13 @@ class CreditsCodename extends funkin.options.OptionsScreen { super.update(elapsed); } + var error:Bool = false; public function checkUpdate():Bool { var curTime:Float = Date.now().getTime(); if(Options.lastUpdated != null && curTime < Options.lastUpdated + 120000) return false; // Fuck you Github rate limits - Nex_isDumb Options.lastUpdated = curTime; - var error:Bool = false; + error = false; //Main.execAsync(function() { var idk = GitHub.getContributors("FNF-CNE-Devs", "CodenameEngine", function(e) { error = true; @@ -62,7 +63,7 @@ class CreditsCodename extends funkin.options.OptionsScreen { 'Total Contributions: ${c.contributions} / ${totalContributions} (${FlxMath.roundDecimal(c.contributions / totalContributions * 100, 2)}%) - Select to open GitHub account', function() CoolUtil.openURL(c.html_url) ); - opt.loadFromGithub(c); + if(!error) opt.loadFromGithub(c); add(opt); } }