From e2cd53d4ffe89360e56a3107ec5ba7151394e7b0 Mon Sep 17 00:00:00 2001 From: Frakits Date: Sat, 27 Apr 2024 14:34:25 +0300 Subject: [PATCH 1/2] fixed Voices crash in charter --- source/funkin/editors/charter/Charter.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/funkin/editors/charter/Charter.hx b/source/funkin/editors/charter/Charter.hx index 05d35dd7..ddb30083 100644 --- a/source/funkin/editors/charter/Charter.hx +++ b/source/funkin/editors/charter/Charter.hx @@ -602,7 +602,7 @@ class Charter extends UIState { var wavesToGenerate:Array<{name:String, sound:FlxSound}> = [ {name: "Inst.ogg", sound: FlxG.sound.music}, ]; - if (Assets.exists(Paths.voices(__song, __diff))) + if (sys.FileSystem.exists(Paths.voices(__song, __diff))) //for some reason Assets.exists returns true regardless if the file actually exists wavesToGenerate.push({name: "Voices.ogg", sound: vocals}); for (strumLine in strumLines) From b2c4cc3777e634e76c83f477661156fee464e690 Mon Sep 17 00:00:00 2001 From: Frakits Date: Sat, 27 Apr 2024 14:40:56 +0300 Subject: [PATCH 2/2] dgf --- source/funkin/editors/charter/Charter.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/funkin/editors/charter/Charter.hx b/source/funkin/editors/charter/Charter.hx index ddb30083..e67b59ba 100644 --- a/source/funkin/editors/charter/Charter.hx +++ b/source/funkin/editors/charter/Charter.hx @@ -602,7 +602,7 @@ class Charter extends UIState { var wavesToGenerate:Array<{name:String, sound:FlxSound}> = [ {name: "Inst.ogg", sound: FlxG.sound.music}, ]; - if (sys.FileSystem.exists(Paths.voices(__song, __diff))) //for some reason Assets.exists returns true regardless if the file actually exists + if (@:privateAccess vocals._sound != null) //for some reason Assets.exists returns true regardless if the file actually exists wavesToGenerate.push({name: "Voices.ogg", sound: vocals}); for (strumLine in strumLines)