From ec4515f4e21ea356fd298033100107d69c684a81 Mon Sep 17 00:00:00 2001
From: Ne_Eo <NeeEoo@users.noreply.github.com>
Date: Wed, 11 Sep 2024 11:04:03 +0200
Subject: [PATCH] Improved dropdown event, to also allow arrays

---
 source/funkin/backend/chart/EventsData.hx | 31 ++++++++++++++++++-----
 source/funkin/backend/utils/CoolUtil.hx   | 13 ++++++++++
 2 files changed, 37 insertions(+), 7 deletions(-)

diff --git a/source/funkin/backend/chart/EventsData.hx b/source/funkin/backend/chart/EventsData.hx
index eff3fd8e..64b8ce93 100644
--- a/source/funkin/backend/chart/EventsData.hx
+++ b/source/funkin/backend/chart/EventsData.hx
@@ -69,7 +69,11 @@ class EventsData {
 		hscriptInterp.variables.set("String", TString);
 		hscriptInterp.variables.set("StrumLine", TStrumLine);
 		hscriptInterp.variables.set("ColorWheel", TColorWheel);
-		hscriptInterp.variables.set("DropDown", Reflect.makeVarArgs((args) -> {return args.length > 0 ? TDropDown([for (arg in args) Std.string(arg)]) : TDropDown(["null"]);}));
+		hscriptInterp.variables.set("DropDown", Reflect.makeVarArgs(function(args:Array<Dynamic>):EventParamType {
+			var flatArgs = CoolUtil.deepFlatten(args);
+			if(flatArgs.length == 0) return TDropDown(["null"]);
+			return TDropDown([for (arg in flatArgs) Std.string(arg)]);
+		}));
 		hscriptInterp.variables.set("Character", TCharacter);
 		hscriptInterp.variables.set("Stage", TStage);
 
@@ -77,11 +81,12 @@ class EventsData {
 		hscriptParser.allowJSON = hscriptParser.allowMetadata = false;
 
 		for (file in Paths.getFolderContent('data/events/', true, BOTH)) {
-			if (Path.extension(file) != "json" && Path.extension(file) != "pack") continue;
-			var eventName:String = Path.withoutExtension(Path.withoutDirectory(file));
+			var ext = Path.extension(file);
+			if (ext != "json" && ext != "pack") continue;
+			var eventName:String = CoolUtil.getFilename(file);
 			var fileTxt:String = Assets.getText(file);
 
-			if (Path.extension(file) == "pack") {
+			if (ext == "pack") {
 				var arr = fileTxt.split("________PACKSEP________");
 				eventName = Path.withoutExtension(arr[0]);
 				fileTxt = arr[2];
@@ -93,13 +98,17 @@ class EventsData {
 			eventsParams.set(eventName, []);
 
 			try {
-				var data:Dynamic = Json.parse(fileTxt);
+				var data:EventInfoFile = cast Json.parse(fileTxt);
 				if (data == null || data.params == null) continue;
 
 				var finalParams:Array<EventParamInfo> = [];
-				for (paramData in cast(data.params, Array<Dynamic>)) {
+				for (paramData in data.params) {
 					try {
-						finalParams.push({name: paramData.name, type: hscriptInterp.expr(hscriptParser.parseString(paramData.type)), defValue: paramData.defaultValue});
+						finalParams.push({
+							name: paramData.name,
+							type: hscriptInterp.expr(hscriptParser.parseString(paramData.type)),
+							defValue: paramData.defaultValue
+						});
 					} catch (e) {trace('Error parsing event param ${paramData.name} - ${eventName}: $e'); finalParams.push(null);}
 				}
 				eventsParams.set(eventName, finalParams);
@@ -110,6 +119,14 @@ class EventsData {
 	}
 }
 
+typedef EventInfoFile = {
+	var params:Array<{
+		var name:String;
+		var type:String;
+		var defaultValue:Dynamic;
+	}>;
+}
+
 typedef EventInfo = {
 	var params:Array<EventParamInfo>;
 	var paramValues:Array<Dynamic>;
diff --git a/source/funkin/backend/utils/CoolUtil.hx b/source/funkin/backend/utils/CoolUtil.hx
index 4927874f..fe02f614 100644
--- a/source/funkin/backend/utils/CoolUtil.hx
+++ b/source/funkin/backend/utils/CoolUtil.hx
@@ -906,6 +906,19 @@ class CoolUtil
 
 		return result.join(seperator);
 	}
+
+	public static function deepFlatten(arr:Array<Dynamic>, ?result:Array<Dynamic>):Array<Dynamic> {
+		if(arr == null) return [];
+		if(result == null) result = [];
+		for (e in arr) {
+			if (Std.isOfType(e, Array)) {
+				deepFlatten(e, result);
+			} else {
+				result.push(e);
+			}
+		}
+		return result;
+	}
 }
 
 /**