From fe02ba7b4bc0f150d7b75aaf45b005ff0bec15df Mon Sep 17 00:00:00 2001
From: Ralty <78720179+Raltyro@users.noreply.github.com>
Date: Sat, 9 Aug 2025 20:15:11 +0700
Subject: [PATCH] Hold Subdivisions should be in control by modders

---
 source/funkin/backend/system/Flags.hx           |  5 +++++
 source/funkin/options/OptionsMenu.hx            |  7 -------
 .../options/categories/ModchartingOptions.hx    | 17 -----------------
 3 files changed, 5 insertions(+), 24 deletions(-)
 delete mode 100644 source/funkin/options/categories/ModchartingOptions.hx

diff --git a/source/funkin/backend/system/Flags.hx b/source/funkin/backend/system/Flags.hx
index 0d0422a9..f57eb7ae 100644
--- a/source/funkin/backend/system/Flags.hx
+++ b/source/funkin/backend/system/Flags.hx
@@ -127,6 +127,9 @@ class Flags {
 
 	public static var DEFAULT_NOTE_MS_LIMIT:Float = 1500;
 	public static var DEFAULT_NOTE_SCALE:Float = 0.7;
+	#if MODCHARTING_FEATURES
+	public static var DEFAULT_MODCHART_HOLD_SUBDIVISIONS:Int = 4;
+	#end
 
 	@:also(funkin.game.Character.FALLBACK_DEAD_CHARACTER)
 	public static var DEFAULT_GAMEOVER_CHARACTER:String = "bf-dead";
@@ -307,6 +310,8 @@ class Flags {
 		for(name=>value in flags)
 			if(!parse(name, value))
 				customFlags.set(name, value);
+
+		Options.modchartingHoldSubdivisions = DEFAULT_MODCHART_HOLD_SUBDIVISIONS;
 	}
 
 	/**
diff --git a/source/funkin/options/OptionsMenu.hx b/source/funkin/options/OptionsMenu.hx
index 99cae93b..3cc3728d 100644
--- a/source/funkin/options/OptionsMenu.hx
+++ b/source/funkin/options/OptionsMenu.hx
@@ -39,13 +39,6 @@ class OptionsMenu extends TreeMenu {
 			state: LanguageOptions
 		},
 		#end
-		#if MODCHARTING_FEATURES
-		{
-			name: 'Modchart Settings >',
-			desc: 'Customize your modcharting experience...',
-			state: ModchartingOptions
-		},
-		#end
 		{
 			name: 'optionsTree.miscellaneous-name',
 			desc: 'optionsTree.miscellaneous-desc',
diff --git a/source/funkin/options/categories/ModchartingOptions.hx b/source/funkin/options/categories/ModchartingOptions.hx
deleted file mode 100644
index 78799f76..00000000
--- a/source/funkin/options/categories/ModchartingOptions.hx
+++ /dev/null
@@ -1,17 +0,0 @@
-package funkin.options.categories;
-
-#if MODCHARTING_FEATURES
-class ModchartingOptions extends TreeMenuScreen {
-	public override function new() {
-		super("Modcharting Options", "Customize your modcharting experience.");
-		add(new NumOption(
-			"Hold Subdivisions",
-			"Subdivides the arrow's hold/sustain tail for smoother visuals, higher values improve quality but can hurt performance",
-			1, // minimum
-			128, // maximum
-			1, // change
-			"modchartingHoldSubdivisions" // save name
-			)); // callback
-	}
-}
-#end
\ No newline at end of file