From 3e75701c1c1850fcaff048fc5243a1bab84b2dde Mon Sep 17 00:00:00 2001 From: KarimAkra Date: Wed, 16 Apr 2025 14:35:28 +0300 Subject: [PATCH] Adjust Arrows control scheme notes sizes for easier reading & pressing Co-Authored-By: MoonDroid <81515012+moondroidcoder@users.noreply.github.com> Co-Authored-By: sector-a <82838084+sector-a@users.noreply.github.com> --- source/funkin/mobile/ui/options/MobileControlsSchemeMenu.hx | 5 ++++- source/funkin/play/PlayState.hx | 2 +- source/funkin/play/notes/Strumline.hx | 6 ++++++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/source/funkin/mobile/ui/options/MobileControlsSchemeMenu.hx b/source/funkin/mobile/ui/options/MobileControlsSchemeMenu.hx index c072c13ec..153e42ada 100644 --- a/source/funkin/mobile/ui/options/MobileControlsSchemeMenu.hx +++ b/source/funkin/mobile/ui/options/MobileControlsSchemeMenu.hx @@ -140,7 +140,8 @@ class MobileControlsSchemeMenu extends MusicBeatSubState hitboxShowcases = new FlxTypedGroup(); for (i in 0...availableSchemes.length) { - var hitboxShowcase:HitboxShowcase = new HitboxShowcase(Std.int(FlxG.width * -0.16 + (1500 * i)), 0, i, currentIndex, availableSchemes[i], onSelectHitbox); + final hitboxShowcase:HitboxShowcase = new HitboxShowcase(Math.floor(FlxG.width * -0.16 + (1500 * i)), 0, i, currentIndex, availableSchemes[i], + onSelectHitbox); hitboxShowcases.add(hitboxShowcase); if (availableSchemes[i] != FunkinHitboxControlSchemes.Arrows) continue; @@ -220,6 +221,8 @@ class MobileControlsSchemeMenu extends MusicBeatSubState addHitbox(true, false, availableSchemes[currentIndex]); hitbox.forEachAlive(function(hint:FunkinHint) { + if (availableSchemes[currentIndex] == FunkinHitboxControlSchemes.Arrows) hint.alpha = 1; + if (!hint.deadZones.contains(cast(currentButton.body, FunkinSprite))) hint.deadZones.push(cast(currentButton.body, FunkinSprite)); }); diff --git a/source/funkin/play/PlayState.hx b/source/funkin/play/PlayState.hx index 5e7a3e7b0..53b94ed44 100644 --- a/source/funkin/play/PlayState.hx +++ b/source/funkin/play/PlayState.hx @@ -1918,7 +1918,7 @@ class PlayState extends MusicBeatSubState } /** - * Configures the position of strumline for note hitbox scheme + * Configures the position of strumline for the default control scheme */ #if mobile function initNoteHitbox() diff --git a/source/funkin/play/notes/Strumline.hx b/source/funkin/play/notes/Strumline.hx index aed5a4407..78d95e81d 100644 --- a/source/funkin/play/notes/Strumline.hx +++ b/source/funkin/play/notes/Strumline.hx @@ -9,10 +9,16 @@ import flixel.tweens.FlxEase; import flixel.tweens.FlxTween; import flixel.util.FlxSort; import funkin.graphics.FunkinSprite; +import flixel.util.FlxColor; +import funkin.play.notes.NoteHoldCover; +import funkin.play.notes.NoteSplash; +import funkin.play.notes.NoteSprite; +import funkin.play.notes.SustainTrail; import funkin.data.song.SongData.SongNoteData; import funkin.util.SortUtil; import funkin.play.notes.notekind.NoteKindManager; import flixel.math.FlxPoint; +import flixel.FlxSprite; /** * A group of sprites which handles the receptor, the note splashes, and the notes (with sustains) for a given player.