From 62a3f73de9d653d4ca5a7d7f4c895fc9fd1a4be7 Mon Sep 17 00:00:00 2001
From: gamerbross <55158797+gamerbross@users.noreply.github.com>
Date: Sat, 11 Oct 2025 04:00:54 +0200
Subject: [PATCH] Better strumline note confirm animations

---
 source/funkin/play/notes/StrumlineNote.hx | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/source/funkin/play/notes/StrumlineNote.hx b/source/funkin/play/notes/StrumlineNote.hx
index 324234cc4..70aa88589 100644
--- a/source/funkin/play/notes/StrumlineNote.hx
+++ b/source/funkin/play/notes/StrumlineNote.hx
@@ -40,7 +40,7 @@ class StrumlineNote extends FunkinSprite
   /**
    * How long to continue the hold note animation after a note is pressed.
    */
-  static final CONFIRM_HOLD_TIME:Float = 0.1;
+  static final CONFIRM_HOLD_TIME:Float = 0.15;
 
   /**
    * How long the hold note animation has been playing after a note is pressed.
@@ -72,9 +72,8 @@ class StrumlineNote extends FunkinSprite
   function onAnimationFinished(name:String):Void
   {
     // Run a timer before we stop playing the confirm animation.
-    // On opponent, this prevent issues with hold notes.
     // On player, this allows holding the confirm key to fall back to press.
-    if (name == 'confirm')
+    if (isPlayer && name == 'confirm')
     {
       confirmHoldTimer = 0;
     }
@@ -143,6 +142,10 @@ class StrumlineNote extends FunkinSprite
   {
     this.active = (forceActive || isAnimationDynamic('confirm'));
     this.playAnimation('confirm', true);
+
+    // On opponent, run a timer to stop playing the confirm animation.
+    // On player, stop the timer to avoid stopping the confirm animation earlier.
+    confirmHoldTimer = isPlayer ? -1 : 0;
   }
 
   public function isConfirm():Bool