From 0c62428fc883c0fa6d09cd403efb287ff3af8c53 Mon Sep 17 00:00:00 2001 From: VioletSnowLeopard Date: Tue, 6 May 2025 23:40:04 -0400 Subject: [PATCH 1/2] fix song text remaining highlighted unintentionally fixes song text squishing --- source/funkin/ui/freeplay/FreeplayState.hx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/funkin/ui/freeplay/FreeplayState.hx b/source/funkin/ui/freeplay/FreeplayState.hx index e77fbb78c..53ec42465 100644 --- a/source/funkin/ui/freeplay/FreeplayState.hx +++ b/source/funkin/ui/freeplay/FreeplayState.hx @@ -568,6 +568,7 @@ class FreeplayState extends MusicBeatSubState // Reminder, this is a callback function being set, rather than these being called here in create() letterSort.changeSelectionCallback = (str) -> { var curSong:Null = grpCapsules.members[curSelected]?.freeplayData; + grpCapsules.members[curSelected].selected = false; switch (str) { @@ -2077,6 +2078,7 @@ class FreeplayState extends MusicBeatSubState var previousVariation:String = currentVariation; var daSong:Null = grpCapsules.members[curSelected].freeplayData; + grpCapsules.members[curSelected].selected = false; // Available variations for current character. We get this since bf is usually `default` variation, and `pico` is `pico` // but sometimes pico can be the default variation (weekend 1 songs), and bf can be `bf` variation (darnell) From 8b80478229f04d329a9b029313493093dc43ebaf Mon Sep 17 00:00:00 2001 From: VioletSnowLeopard Date: Thu, 8 May 2025 16:55:39 -0400 Subject: [PATCH 2/2] Fix squashed text for real this time --- source/funkin/ui/freeplay/SongMenuItem.hx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/source/funkin/ui/freeplay/SongMenuItem.hx b/source/funkin/ui/freeplay/SongMenuItem.hx index 43215ba3c..23376623c 100644 --- a/source/funkin/ui/freeplay/SongMenuItem.hx +++ b/source/funkin/ui/freeplay/SongMenuItem.hx @@ -506,8 +506,6 @@ class SongMenuItem extends FlxSpriteGroup spr.visible = value; } - textAppear(); - updateSelected(); } @@ -678,7 +676,11 @@ class SongMenuItem extends FlxSpriteGroup */ public function confirm():Void { - if (songText != null) songText.flickerText(); + if (songText != null) + { + textAppear(); + songText.flickerText(); + } if (pixelIcon != null && pixelIcon.visible) { pixelIcon.animation.play('confirm');