From 83216e171c1053c2e0dce7432ad13e0b40332c95 Mon Sep 17 00:00:00 2001 From: Hyper_ <40342021+NotHyper-474@users.noreply.github.com> Date: Sun, 4 May 2025 21:43:42 -0300 Subject: [PATCH 01/11] Remove unnecessary Tracy frame mark This is already done by OpenFL --- source/funkin/util/WindowUtil.hx | 6 ------ 1 file changed, 6 deletions(-) diff --git a/source/funkin/util/WindowUtil.hx b/source/funkin/util/WindowUtil.hx index ee64660cb..8f2ae227f 100644 --- a/source/funkin/util/WindowUtil.hx +++ b/source/funkin/util/WindowUtil.hx @@ -85,12 +85,6 @@ class WindowUtil */ public static function initTracy():Void { - // Apply a marker to indicate frame end for the Tracy profiler. - // Do this only if Tracy is configured to prevent lag. - openfl.Lib.current.stage.addEventListener(openfl.events.Event.EXIT_FRAME, (e:openfl.events.Event) -> { - cpp.vm.tracy.TracyProfiler.frameMark(); - }); - var appInfoMessage = funkin.util.logging.CrashHandler.buildSystemInfo(); trace("Friday Night Funkin': Connection to Tracy profiler successful."); From a5921ab96c703b99fb94e1cef0039e7aa6c7e88f Mon Sep 17 00:00:00 2001 From: KarimAkra Date: Wed, 4 Jun 2025 16:31:15 +0300 Subject: [PATCH 02/11] Disable the lime.utils.AssetCache version macro --- project.hxp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/project.hxp b/project.hxp index f90d3f3e2..06fdde9f3 100644 --- a/project.hxp +++ b/project.hxp @@ -762,6 +762,10 @@ class Project extends HXProject // Enable OpenFL's error handler. Required for the crash logger. setHaxedef("openfl-enable-handle-error"); + // Disable a macro in Lime that generates a random number for Assets.cache.version every build. + // This doesn't seem to be of any use and it causes lime.utils.AssetCache to be re-compiled on every build. + setHaxeDef("lime_disable_assets_version"); + // Enable stack trace tracking. Good for debugging but has a (minor) performance impact. setHaxedef("HXCPP_CHECK_POINTER"); setHaxedef("HXCPP_STACK_LINE"); From 5177e1275eb2fb2b016224c139e84debb421b895 Mon Sep 17 00:00:00 2001 From: Lasercar <64717068+Lasercar@users.noreply.github.com> Date: Sun, 2 Mar 2025 14:46:43 +1000 Subject: [PATCH 03/11] Add all tween types --- source/funkin/play/event/FocusCameraSongEvent.hx | 12 ++++++++++++ source/funkin/play/event/ScrollSpeedEvent.hx | 14 +++++++++++++- source/funkin/play/event/ZoomCameraSongEvent.hx | 14 +++++++++++++- 3 files changed, 38 insertions(+), 2 deletions(-) diff --git a/source/funkin/play/event/FocusCameraSongEvent.hx b/source/funkin/play/event/FocusCameraSongEvent.hx index 3198e0792..137a9fbc5 100644 --- a/source/funkin/play/event/FocusCameraSongEvent.hx +++ b/source/funkin/play/event/FocusCameraSongEvent.hx @@ -218,9 +218,21 @@ class FocusCameraSongEvent extends SongEvent 'Smooth Step In' => 'smoothStepIn', 'Smooth Step Out' => 'smoothStepOut', 'Smooth Step In/Out' => 'smoothStepInOut', + 'Smoother Step In' => 'smootherStepIn', + 'Smoother Step Out' => 'smootherStepOut', + 'Smoother Step In/Out' => 'smootherStepInOut', 'Elastic In' => 'elasticIn', 'Elastic Out' => 'elasticOut', 'Elastic In/Out' => 'elasticInOut', + 'Back In' => 'backIn', + 'Back Out' => 'backOut', + 'Back In/Out' => 'backInOut', + 'Bounce In' => 'bounceIn', + 'Bounce Out' => 'bounceOut', + 'Bounce In/Out' => 'bounceInOut', + 'Circ In' => 'circIn', + 'Circ Out' => 'circOut', + 'Circ In/Out' => 'circInOut', 'Instant (Ignores duration)' => 'INSTANT', 'Classic (Ignores duration)' => 'CLASSIC' ] diff --git a/source/funkin/play/event/ScrollSpeedEvent.hx b/source/funkin/play/event/ScrollSpeedEvent.hx index bc0e99ba5..227fa0be2 100644 --- a/source/funkin/play/event/ScrollSpeedEvent.hx +++ b/source/funkin/play/event/ScrollSpeedEvent.hx @@ -149,9 +149,21 @@ class ScrollSpeedEvent extends SongEvent 'Smooth Step In' => 'smoothStepIn', 'Smooth Step Out' => 'smoothStepOut', 'Smooth Step In/Out' => 'smoothStepInOut', + 'Smoother Step In' => 'smootherStepIn', + 'Smoother Step Out' => 'smootherStepOut', + 'Smoother Step In/Out' => 'smootherStepInOut', 'Elastic In' => 'elasticIn', 'Elastic Out' => 'elasticOut', - 'Elastic In/Out' => 'elasticInOut' + 'Elastic In/Out' => 'elasticInOut', + 'Back In' => 'backIn', + 'Back Out' => 'backOut', + 'Back In/Out' => 'backInOut', + 'Bounce In' => 'bounceIn', + 'Bounce Out' => 'bounceOut', + 'Bounce In/Out' => 'bounceInOut', + 'Circ In' => 'circIn', + 'Circ Out' => 'circOut', + 'Circ In/Out' => 'circInOut' ] }, { diff --git a/source/funkin/play/event/ZoomCameraSongEvent.hx b/source/funkin/play/event/ZoomCameraSongEvent.hx index 0c34028c8..d3635f893 100644 --- a/source/funkin/play/event/ZoomCameraSongEvent.hx +++ b/source/funkin/play/event/ZoomCameraSongEvent.hx @@ -158,9 +158,21 @@ class ZoomCameraSongEvent extends SongEvent 'Smooth Step In' => 'smoothStepIn', 'Smooth Step Out' => 'smoothStepOut', 'Smooth Step In/Out' => 'smoothStepInOut', + 'Smoother Step In' => 'smootherStepIn', + 'Smoother Step Out' => 'smootherStepOut', + 'Smoother Step In/Out' => 'smootherStepInOut', 'Elastic In' => 'elasticIn', 'Elastic Out' => 'elasticOut', - 'Elastic In/Out' => 'elasticInOut' + 'Elastic In/Out' => 'elasticInOut', + 'Back In' => 'backIn', + 'Back Out' => 'backOut', + 'Back In/Out' => 'backInOut', + 'Bounce In' => 'bounceIn', + 'Bounce Out' => 'bounceOut', + 'Bounce In/Out' => 'bounceInOut', + 'Circ In' => 'circIn', + 'Circ Out' => 'circOut', + 'Circ In/Out' => 'circInOut' ] } ]); From 0345107e71e175f20ef0e5131c00c100665c7cdd Mon Sep 17 00:00:00 2001 From: sector-a <82838084+sector-a@users.noreply.github.com> Date: Thu, 5 Jun 2025 01:17:33 +0300 Subject: [PATCH 04/11] Disable inst select menu on mobile --- source/funkin/ui/freeplay/FreeplayState.hx | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/source/funkin/ui/freeplay/FreeplayState.hx b/source/funkin/ui/freeplay/FreeplayState.hx index dce3fcda0..a2893bf70 100644 --- a/source/funkin/ui/freeplay/FreeplayState.hx +++ b/source/funkin/ui/freeplay/FreeplayState.hx @@ -2290,16 +2290,22 @@ class FreeplayState extends MusicBeatSubState var altInstrumentalIds:Array = targetSong.listAltInstrumentalIds(targetDifficultyId, targetDifficulty?.variation ?? Constants.DEFAULT_VARIATION) ?? []; + #if !mobile if (altInstrumentalIds.length > 0) { var instrumentalIds = [baseInstrumentalId].concat(altInstrumentalIds); openInstrumentalList(cap, instrumentalIds); + + return; } - else - { - trace('NO ALTS'); - capsuleOnConfirmDefault(cap); - } + #end + + #if mobile + trace('ALTS ARE DISABLED'); + #else + trace('NO ALTS'); + #end + capsuleOnConfirmDefault(cap); } public function getControls():Controls From 067a04e0698276f9952481d326499a9cd404fc09 Mon Sep 17 00:00:00 2001 From: VioletSnowLeopard Date: Wed, 7 May 2025 23:24:57 -0400 Subject: [PATCH 05/11] Remove this unnecessary line `curSelected` is always set to 0 directly above this --- source/funkin/ui/freeplay/FreeplayState.hx | 4 ---- 1 file changed, 4 deletions(-) diff --git a/source/funkin/ui/freeplay/FreeplayState.hx b/source/funkin/ui/freeplay/FreeplayState.hx index a2893bf70..081e1bedc 100644 --- a/source/funkin/ui/freeplay/FreeplayState.hx +++ b/source/funkin/ui/freeplay/FreeplayState.hx @@ -833,10 +833,6 @@ class FreeplayState extends MusicBeatSubState currentFilteredSongs = tempSongs; curSelected = 0; - // If curSelected is 0, the result will be null and fall back to the rememberedSongId. - // We set this so if we change the filter, we'd remain on the same song if it's still in the list. - rememberedSongId = grpCapsules.members[curSelected]?.freeplayData?.data.id ?? rememberedSongId; - grpCapsules.killMembers(); // Initialize the random capsule, with empty/blank info (which we display once bf/pico does his hand) From 3bbb4b06c8c1a1885a18d4354fcfa4363a0c6c75 Mon Sep 17 00:00:00 2001 From: Lasercar <64717068+Lasercar@users.noreply.github.com> Date: Mon, 5 May 2025 16:10:30 +1000 Subject: [PATCH 06/11] no character? --- .../dialogs/ChartEditorCharacterIconSelectorMenu.hx | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/source/funkin/ui/debug/charting/dialogs/ChartEditorCharacterIconSelectorMenu.hx b/source/funkin/ui/debug/charting/dialogs/ChartEditorCharacterIconSelectorMenu.hx index 2c9de5c62..01b7c59ac 100644 --- a/source/funkin/ui/debug/charting/dialogs/ChartEditorCharacterIconSelectorMenu.hx +++ b/source/funkin/ui/debug/charting/dialogs/ChartEditorCharacterIconSelectorMenu.hx @@ -22,7 +22,8 @@ class ChartEditorCharacterIconSelectorMenu extends ChartEditorBaseMenu public var charSelectScroll:ScrollView; public var charIconName:Label; - var currentCharButton:Button; + var currentCharButton:Null