gabry/Funkin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: use null-safe list functions in Medals and Leaderboards

Browse Source
This commit is contained in:
Hyper_
2025-09-08 22:45:32 +08:00
committed by Hundrec
parent f3c7cfd799
commit 88fc5f9ed6
2 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/funkin/api/newgrounds/Leaderboards.hx
+2 -8
View File
@@ -37,10 +37,7 @@ class Leaderboards
if (NewgroundsClient.instance.isLoggedIn())
{
var leaderboardList = NewgroundsClient.instance.leaderboards;
if (leaderboardList == null) return;
var leaderboardData:Null<LeaderboardData> = leaderboardList.get(leaderboard.getId());
var leaderboardData:Null<LeaderboardData> = listLeaderboardData().get(leaderboard.getId());
if (leaderboardData != null)
{
leaderboardData.postScore(score, function(outcome:Outcome<CallError>):Void {
@@ -67,10 +64,7 @@ class Leaderboards
// Silently reject retrieving scores from unknown leaderboards.
if (leaderboard == Leaderboard.Unknown) return;
var leaderboardList = NewgroundsClient.instance.leaderboards;
if (leaderboardList == null) return;
var leaderboardData:Null<LeaderboardData> = leaderboardList.get(leaderboard.getId());
var leaderboardData:Null<LeaderboardData> = listLeaderboardData().get(leaderboard.getId());
if (leaderboardData == null) return;
var user:Null<User> = null;
source/funkin/api/newgrounds/Medals.hx
+2 -10
View File
@@ -30,11 +30,7 @@ class Medals
{
if (NewgroundsClient.instance.isLoggedIn())
{
var medalList = NewgroundsClient.instance.medals;
@:privateAccess
if (medalList == null || medalList._map == null) return;
var medalData:Null<MedalData> = medalList.get(medal.getId());
var medalData:Null<MedalData> = listMedalData().get(medal.getId());
@:privateAccess
if (medalData == null || medalData._data == null)
{
@@ -120,11 +116,7 @@ class Medals
public static function fetchMedalData(medal:Medal):Null<FetchedMedalData>
{
var medalList = NewgroundsClient.instance.medals;
@:privateAccess
if (medalList == null || medalList._map == null) return null;
var medalData:Null<MedalData> = medalList.get(medal.getId());
var medalData:Null<MedalData> = listMedalData().get(medal.getId());
@:privateAccess
if (medalData == null || medalData._data == null)
{